mt4R for new MQL4

Thanks for your great work!

بهرحال, the R chart created by Arbomat seems to come and go in a fraction of a second at the moment of loading the EA. What could be the reason?

R chart created by Trendomat is appearing good. I'm using the same PC and the same MT4.

پڻ, sometimes appears this message in the experts tab:

Great thank you and I'm sorry about terrible porting quality...

I've fixed RGetBoo/RGetInteger bug at v1.4.0-SNAPSHOT-b6.

ايڊٽ ڪريو: Next time I'll just open an issue at your repo if you don't mind. I don't want to spam the comments section here ;)

I'll welcome for iissue from you if you feel to report something about this!

Excellent job! Thanks for the instant fixes 🙂 !!!

Two more things:

• RGetInteger: AExpression: PChar should be PWideChar and subsequently Result := TRConsole(AHandle).GetInteger(WideStringToString(AExpression, CP_ACP))
• RGetBool: Same as above 🙂

// assign string to variable given by name
procedure RAssignString(AHandle: LongInt; AVariable: PWideChar; AValue: PChar (should also be PWideChar?)); stdcall;
begin
  if isValid(AHandle) then
    TRConsole(AHandle).AssignString(WideStringToString(AVariable, CP_ACP), WideStringToString(AValue, CP_ACP));

end;

Thanks for bug report, I've fixed at v1.4.0-SNAPSHOT-b5.

Please update the dll and the include file, because of minor version number is changed from before b3.

Rf("ڀيرا",ڀيرا);

Thanks for your bug report!

From the investigation, the array processing in RAssingStringVector is not correctly ported to new MQL4.

I've updated the DLL, so please get the latest version from GitHub.

هن نسخي ۾, DLL-hardcoded minor version number updated to 4, so please also copy MQL4/Include/mt4R.mqh.

Thanks for fixing it! Works great! One more minor change is required though:

// assign string to variable given by name
procedure RAssignString(AHandle: LongInt; AVariable: PWideChar; AValue: PChar (should also be PWideChar?)); stdcall;
begin
  if isValid(AHandle) then
    TRConsole(AHandle).AssignString(WideStringToString(AVariable, CP_ACP), WideStringToString(AValue, CP_ACP));

end;

Fist of all: Thank you so much for porting it to the new version! Excellent job!

بهرحال, I've encountered a problem. See this simple script:

//+------------------------------------------------------------------+
//|                                                  TestNewMt4R.mq4 |
//|                                                                  |
//|                                                                  |
//+------------------------------------------------------------------+
#ملڪيت جي حق اشاعت ""
#ملڪيت جي لنڪ      ""
#property version   "1.00"
#property strict

#include <mt4R.mqh>

#define RPATH "ڊي:/Program Files/R/R-3.0.2/bin/i386/Rterm.exe --no-save"
#define RDEBUG 2

string times[1000];
//+------------------------------------------------------------------+
//| Script program start function                                    |
//+------------------------------------------------------------------+
void OnStart()
  {
   StartR(RPATH,RDEBUG);
   لاءِ(int i=0; i<1000; i++)
     {
      ڀيرا[i]=TimeToString(iTime(علامت(),عرصو(),i),TIME_DATE|TIME_SECONDS);
     }
   Rf("ڀيرا",ڀيرا);
   Rx("gc()");
   StopR();  
  }
//+------------------------------------------------------------------+

It crashes when trying to execute

Rf("ڀيرا",ڀيرا);

And I don't know why. I think the problem might be the one you mentioned regarding strings. بهرحال, I cannot resolve it by myself so help is very much appreciated.

مهرباني!

ايڊٽ ڪريو:

I checked DebugView and it seems that the whole String handling is somehow broken, مثال,

void OnStart()
  {
   StartR(RPATH,RDEBUG);
   string testString = "This is a string copy test.";

   Rs("rString", testString);

   Rx("gc()");
   StopR();
  }

Results in:

تار in new MQL4 is not an array of char but an array of wchar_t.

If your old indicator/script/EA which worked on MT4 build509 or earlier uses تار and passes it to DLL functions, you MUST change the function to wchar_t نسخو.

مثال طور, if it uses ShellExecuteA, change it to ShellExecuteW.

Unfortunately if the dll you use does not provide wchar_t version functions like mt4R.dll, you must modify DLL implementation, or convert an تار to an array of char پاران WideCharToMultiByte Win32API.

نوٽ: I haven't tried WideCharToMultiByte yet on new MQL4, so I don't know you can use WideCharToMultiByte without or with any problem.

At the ٺاھڻ 600 release topic, it is said as follows:

Can you specify what changes were necessary to update the dll? I wasn't aware that dlls need to be changed to fit MQL5's format. Have you any links on this subject?